Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 17413013: Revert "Support runtime check of function types." (Closed)

Created:
7 years, 6 months ago by Johnni Winther
Modified:
7 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Support runtime check of function types." This reverts commit r24286. BUG= Committed: https://code.google.com/p/dart/source/detail?r=24288

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -3412 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/closure.dart View 5 chunks +20 lines, -35 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/compile_time_constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/compiler.dart View 2 chunks +2 lines, -20 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_types.dart View 6 chunks +2 lines, -37 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/enqueue.dart View 7 chunks +7 lines, -33 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 12 chunks +68 lines, -276 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 21 chunks +45 lines, -205 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/namer.dart View 6 chunks +2 lines, -103 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart View 16 chunks +27 lines, -207 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 2 chunks +0 lines, -7 lines 0 comments Download
sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 20 chunks +16 lines, -128 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 3 chunks +44 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/nodes.dart View 4 chunks +5 lines, -28 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/optimize.dart View 1 chunk +2 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/nodes.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/universe/universe.dart View 3 chunks +1 line, -27 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/util/link.dart View 1 chunk +1 line, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/util/link_implementation.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/lib/foreign_helper.dart View 2 chunks +0 lines, -44 lines 0 comments Download
M sdk/lib/_internal/lib/js_helper.dart View 2 chunks +1 line, -11 lines 0 comments Download
M sdk/lib/_internal/lib/js_rti.dart View 7 chunks +22 lines, -280 lines 0 comments Download
M tests/co19/co19-dart2js.status View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/subtype_test.dart View 3 chunks +0 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 4 chunks +15 lines, -23 lines 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -3 lines 0 comments Download
D tests/language/function_subtype0_test.dart View 1 chunk +0 lines, -87 lines 0 comments Download
D tests/language/function_subtype1_test.dart View 1 chunk +0 lines, -74 lines 0 comments Download
D tests/language/function_subtype_bound_closure0_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D tests/language/function_subtype_bound_closure1_test.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D tests/language/function_subtype_bound_closure2_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D tests/language/function_subtype_bound_closure3_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/language/function_subtype_bound_closure4_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/language/function_subtype_bound_closure5_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/language/function_subtype_bound_closure6_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/language/function_subtype_bound_closure7_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/language/function_subtype_call0_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/language/function_subtype_call1_test.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D tests/language/function_subtype_call2_test.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D tests/language/function_subtype_cast0_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/language/function_subtype_cast1_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/language/function_subtype_cast2_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D tests/language/function_subtype_cast3_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/language/function_subtype_checked0_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D tests/language/function_subtype_closure0_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/language/function_subtype_closure1_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/language/function_subtype_factory0_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/language/function_subtype_factory1_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/language/function_subtype_inline0_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D tests/language/function_subtype_inline1_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D tests/language/function_subtype_local0_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D tests/language/function_subtype_local1_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D tests/language/function_subtype_local2_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D tests/language/function_subtype_local3_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/language/function_subtype_local4_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D tests/language/function_subtype_local5_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/language/function_subtype_named1_test.dart View 1 chunk +0 lines, -69 lines 0 comments Download
D tests/language/function_subtype_named2_test.dart View 1 chunk +0 lines, -56 lines 0 comments Download
D tests/language/function_subtype_not0_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/language/function_subtype_not1_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/language/function_subtype_not2_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D tests/language/function_subtype_not3_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/language/function_subtype_null.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/language/function_subtype_optional1_test.dart View 1 chunk +0 lines, -71 lines 0 comments Download
tests/language/function_subtype_optional2_test.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D tests/language/function_subtype_setter0_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D tests/language/function_subtype_top_level0_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D tests/language/function_subtype_top_level1_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/language/function_subtype_typearg0_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/language/function_subtype_typearg1_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/language/function_subtype_typearg2_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/language/function_subtype_typearg3_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/language/function_subtype_typearg4_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
M tests/language/language_dart2js.status View 4 chunks +12 lines, -3 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
TBR
7 years, 6 months ago (2013-06-21 14:01:11 UTC) #1
Johnni Winther
Committed patchset #1 manually as r24288 (presubmit successful).
7 years, 6 months ago (2013-06-21 14:04:24 UTC) #2
karlklose
7 years, 6 months ago (2013-06-21 15:25:57 UTC) #3
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698