Move getters from Options to Platform

Move getters from Options to Platform

The getters for executable, script and version are now statics on
Platform. I kept them on Options for now, but updated most tests to
use Platform.

R=ajohnsen@google.com, floitsch@google.com, iposva@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=24401

[Søren Gjesse, 2013-06-20 15:33:20]

This is in preparation for refactoring/removing the Options class.

[Anders Johnsen, 2013-06-20 15:57:43]

LGTM,

my only question is the Platform.script move. Do we expect this to stay as an
Option, along with arguments?

https://codereview.chromium.org/17406010/diff/1/utils/testrunner/utils.dart
File utils/testrunner/utils.dart (right):

https://codereview.chromium.org/17406010/diff/1/utils/testrunner/utils.dart#n...
utils/testrunner/utils.dart:96: var libDirectory =
makePathAbsolute(Platform.script);
Isn't this file using an older version of Dart?

[Bob Nystrom, 2013-06-20 16:51:46]

Much better API. :) I'm really excited about this change.

[Ivan Posva, 2013-06-21 00:59:31]

On 2013/06/20 15:33:20, Søren Gjesse wrote:
> This is in preparation for refactoring/removing the Options class.

It will make reviewing this change easier if you outline (not necessarily within
the CL) what the plans are for the Options class and the whole area of passing
parameters to isolates. Be the isolates spawned and launched directly from an
embedder.

Thanks,
-Ivan

[floitsch, 2013-06-21 16:01:07]

LGTM (once Anders' comment is addressed).

[Ivan Posva, 2013-06-24 21:16:46]

LGTM with comments.

-Ivan

https://codereview.chromium.org/17406010/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/17406010/diff/1/runtime/bin/main.cc#newcode410
runtime/bin/main.cc:410: Dart_Handle platform_class = Dart_GetClass(
It seems that this CL is out of sync. Dart_GetClass has been deprecated and has
been replaced with Dart_GetType.

https://codereview.chromium.org/17406010/diff/1/runtime/bin/main.cc#newcode441
runtime/bin/main.cc:441: Dart_Handle runtime_options_class = Dart_GetClass(
Please use Dart_GetType instead of Dart_GetClass.

[Søren Gjesse, 2013-06-25 12:57:21]

Committed patchset #2 manually as r24401 (presubmit successful).