Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 174053004: Revert "Adding package:code_transformers for unifying common transformers code" (Closed)

Created:
6 years, 10 months ago by blois
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Adding package:code_transformers for unifying common transformers code" This reverts commit 32859. It's failing to find the Dart SDK under a number of cases. TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=32866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1262 lines) Patch
D pkg/code_transformers/AUTHORS View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/code_transformers/LICENSE View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/code_transformers/PATENTS View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/code_transformers/lib/resolver.dart View 1 chunk +0 lines, -10 lines 0 comments Download
D pkg/code_transformers/lib/src/dart_sdk.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D pkg/code_transformers/lib/src/resolver.dart View 1 chunk +0 lines, -81 lines 0 comments Download
D pkg/code_transformers/lib/src/resolver_impl.dart View 1 chunk +0 lines, -545 lines 0 comments Download
D pkg/code_transformers/lib/src/resolver_transformer.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D pkg/code_transformers/lib/src/test_harness.dart View 1 chunk +0 lines, -124 lines 0 comments Download
D pkg/code_transformers/lib/tests.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D pkg/code_transformers/pubspec.yaml View 1 chunk +0 lines, -14 lines 0 comments Download
D pkg/code_transformers/test/resolver_test.dart View 1 chunk +0 lines, -304 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
Committed patchset #1 manually as r32866 (presubmit successful).
6 years, 10 months ago (2014-02-20 19:21:27 UTC) #1
Siggi Cherem (dart-lang)
6 years, 10 months ago (2014-02-20 22:34:15 UTC) #2
Message was sent while issue was closed.
(lgtm)

Powered by Google App Engine
This is Rietveld 408576698