Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1740433002: Give IE and Safari tags platform restrictions. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Give IE and Safari tags platform restrictions. This means we don't have to explicitly tag those tests as Windows- of Mac OS-only. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/617d984ac4b6242e50815e27397512d6952519b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M dart_test.yaml View 1 chunk +9 lines, -3 lines 0 comments Download
M test/runner/browser/internet_explorer_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/runner/browser/safari_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 10 months ago (2016-02-24 20:27:48 UTC) #1
kevmoo
lgtm
4 years, 10 months ago (2016-02-24 21:52:56 UTC) #2
nweiz
4 years, 10 months ago (2016-02-24 23:48:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
617d984ac4b6242e50815e27397512d6952519b9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698