Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 174033002: Add missing mutex protection for timeout queue with mutex (Closed)

Created:
6 years, 10 months ago by Søren Gjesse
Modified:
6 years, 10 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Anders Johnsen
Visibility:
Public.

Description

Add missing mutex protection for timeout queue with mutex Holding the timer_mutex_ is required to access the timeout_queue_ data structure. This was missing for epoll events. R=kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=32856

Patch Set 1 #

Patch Set 2 : Add a couple of ASSERTs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M runtime/bin/eventhandler.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/eventhandler_linux.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
6 years, 10 months ago (2014-02-20 17:12:20 UTC) #1
kustermann
LGTM
6 years, 10 months ago (2014-02-20 17:18:39 UTC) #2
Søren Gjesse
6 years, 10 months ago (2014-02-20 17:21:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r32856 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698