Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 17397005: Bugfix for tools/utils.py: Inherit environment to cmd.exe. (Closed)

Created:
7 years, 6 months ago by kustermann
Modified:
7 years, 6 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Bugfix for tools/utils.py: Inherit environment to cmd.exe. On windows we run "svn" in a shell. But the shell cannot find svn.exe if PATH is not set. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=24212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/utils.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kustermann
7 years, 6 months ago (2013-06-19 14:25:00 UTC) #1
ricow1
LGTM
7 years, 6 months ago (2013-06-19 16:56:17 UTC) #2
kustermann
7 years, 6 months ago (2013-06-20 08:22:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24212 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698