Fix for issue 11262.

Fix for issue 11262.

- Add Dart_InstanceGetType
- Wire Dart_New, Dart_Invoke and Dart_[G|S]etField to use types

R=regis@google.com, vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24195

[vsm, 2013-06-18 22:45:51]

https://codereview.chromium.org/17390008/diff/5001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/17390008/diff/5001/runtime/include/dart_api.h...
runtime/include/dart_api.h:1813: * instance field.  If 'container' is a type,
then this function will
This seems ambiguous now as a type is also an object.  What are the semantics of
accessing Integer.hashCode or Map.toString() via this API?  Are they treated as
static or instance invocations?

From the impl, it looks like type/static takes precedence.

[siva, 2013-06-18 23:09:54]

https://codereview.chromium.org/17390008/diff/5001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/17390008/diff/5001/runtime/include/dart_api.h...
runtime/include/dart_api.h:1813: * instance field.  If 'container' is a type,
then this function will
Yes if it is a type then it would be a static call. The ambiguity is in the
comment? Should I change the comment to type, object or library?

On 2013/06/18 22:45:51, vsm wrote:
> This seems ambiguous now as a type is also an object.  What are the semantics
of
> accessing Integer.hashCode or Map.toString() via this API?  Are they treated
as
> static or instance invocations?
> 
> From the impl, it looks like type/static takes precedence.

[vsm, 2013-06-18 23:18:17]

https://codereview.chromium.org/17390008/diff/5001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/17390008/diff/5001/runtime/include/dart_api.h...
runtime/include/dart_api.h:1813: * instance field.  If 'container' is a type,
then this function will
Ultimately, I think the API itself is ambiguous as a type object refers to both
a class and an instance and both are containers.  I think a separate GetField
and GetStaticField, etc., would be clearer.

Short of that, you could rewrite the comment to make it clear that a type object
always refers to a static field.

On 2013/06/18 23:09:54, siva wrote:
> Yes if it is a type then it would be a static call. The ambiguity is in the
> comment? Should I change the comment to type, object or library?
> 
> On 2013/06/18 22:45:51, vsm wrote:
> > This seems ambiguous now as a type is also an object.  What are the
semantics
> of
> > accessing Integer.hashCode or Map.toString() via this API?  Are they treated
> as
> > static or instance invocations?
> > 
> > From the impl, it looks like type/static takes precedence.
>

[siva, 2013-06-18 23:42:33]

https://codereview.chromium.org/17390008/diff/5001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/17390008/diff/5001/runtime/include/dart_api.h...
runtime/include/dart_api.h:1813: * instance field.  If 'container' is a type,
then this function will
I think I will add a comment in the API that access to fields or methods of a
type object cannot be done using the methods Dart_Invoke, Dart_GetField and
Dart_SetField.

If we come across a use case where access of these fields or methods of a type
object is needed through the API we can look
at adding special methods for it.

We already have Dart_ToString, Dart_IdentityEquals for the 'toString' and '=='
methods.

On 2013/06/18 23:18:17, vsm wrote:
> Ultimately, I think the API itself is ambiguous as a type object refers to
both
> a class and an instance and both are containers.  I think a separate GetField
> and GetStaticField, etc., would be clearer.
> 
> Short of that, you could rewrite the comment to make it clear that a type
object
> always refers to a static field.
> 
> On 2013/06/18 23:09:54, siva wrote:
> > Yes if it is a type then it would be a static call. The ambiguity is in the
> > comment? Should I change the comment to type, object or library?
> > 
> > On 2013/06/18 22:45:51, vsm wrote:
> > > This seems ambiguous now as a type is also an object.  What are the
> semantics
> > of
> > > accessing Integer.hashCode or Map.toString() via this API?  Are they
treated
> > as
> > > static or instance invocations?
> > > 
> > > From the impl, it looks like type/static takes precedence.
> > 
>

[vsm, 2013-06-19 04:26:06]

lgtm

[regis, 2013-06-19 08:26:34]

LGTM

[siva, 2013-06-19 18:22:38]

Committed patchset #3 manually as r24195 (presubmit successful).