Correctly reflect on intercepted classes.

Correctly reflect on intercepted classes.

BUG=http://dartbug.com/11309
R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24129

Committed: https://code.google.com/p/dart/source/detail?r=24134

[ngeoffray, 2013-06-18 09:17:15]

LGTM

https://codereview.chromium.org/17376005/diff/4001/dart/sdk/lib/_internal/lib...
File dart/sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/17376005/diff/4001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_helper.dart:571: static getConstructor(String
className) {
Note that if you want to use this for implementing something like 'newInstance',
it won't work. But maybe you already know that, and are handling it differently
somewhere?

[ahe, 2013-06-18 09:25:36]

Thank you, Nicolas!

https://codereview.chromium.org/17376005/diff/4001/dart/sdk/lib/_internal/lib...
File dart/sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/17376005/diff/4001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_helper.dart:571: static getConstructor(String
className) {
On 2013/06/18 09:17:15, ngeoffray wrote:
> Note that if you want to use this for implementing something like
'newInstance',
> it won't work. But maybe you already know that, and are handling it
differently
> somewhere?

ClassMirror.newInstance relies on finding the corresponding factory.  It doesn't
work reliably yet, but I intend to store factories in a way that makes it easy
to discover them at runtime.

I make no connection between the constructor returned by this method and
factories.

[ahe, 2013-06-18 09:26:44]

Committed patchset #1 manually as r24129 (presubmit successful).

[ahe, 2013-06-18 11:08:40]

PTAL second attempt, had to revert the first attempt.

[ngeoffray, 2013-06-18 11:17:27]

LGTM

https://codereview.chromium.org/17376005/diff/12001/dart/sdk/lib/_internal/li...
File dart/sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/17376005/diff/12001/dart/sdk/lib/_internal/li...
dart/sdk/lib/_internal/lib/js_mirrors.dart:247: if (constructorOrInterceptor ==
null) {
Is the code below still relevant?

[ahe, 2013-06-18 11:19:56]

Thank you, Nicolas.

https://codereview.chromium.org/17376005/diff/12001/dart/sdk/lib/_internal/li...
File dart/sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/17376005/diff/12001/dart/sdk/lib/_internal/li...
dart/sdk/lib/_internal/lib/js_mirrors.dart:247: if (constructorOrInterceptor ==
null) {
On 2013/06/18 11:17:27, ngeoffray wrote:
> Is the code below still relevant?

Yes.  For native classes.

[ahe, 2013-06-18 11:20:30]

Committed patchset #2 manually as r24134 (presubmit successful).