Issue 173713002: Add --hide-package-warnings option.

Issue 173713002: Add --hide-package-warnings option. (Closed)

Created:
6 years, 10 months ago by Johnni Winther

Modified:
6 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add --hide-package-warnings option. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=32879

Patch Set 3 : Updated cf. comment #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -22 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/apiimpl.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 2	7 chunks	+56 lines, -19 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart2js.dart	View		2 chunks	+4 lines, -0 lines	0 comments	Download
A	tests/compiler/dart2js/hide_package_warnings_test.dart	View	1	1 chunk	+104 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/in_user_code_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/memory_compiler.dart	View		3 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM! https://codereview.chromium.org/173713002/diff/30001/sdk/lib/_internal/compiler/implementation/compiler.dart File sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/173713002/diff/30001/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode768 sdk/lib/_internal/compiler/implementation/compiler.dart:768: MetadataAnnotation annotation = node; This should not be ...

6 years, 10 months ago (2014-02-20 19:24:31 UTC) #2

Johnni Winther

https://codereview.chromium.org/173713002/diff/30001/sdk/lib/_internal/compiler/implementation/compiler.dart File sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/173713002/diff/30001/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode768 sdk/lib/_internal/compiler/implementation/compiler.dart:768: MetadataAnnotation annotation = node; On 2014/02/20 19:24:32, floitsch wrote: ...

6 years, 10 months ago (2014-02-21 08:32:14 UTC) #3

Johnni Winther

6 years, 10 months ago (2014-02-21 08:34:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r32879 (presubmit successful).

Expand Messages | Collapse Messages