Issue 173683002: Slightly speed up http-parser and http-header-writing.

Issue 173683002: Slightly speed up http-parser and http-header-writing. (Closed)

Created:
6 years, 10 months ago by Anders Johnsen

Modified:
6 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Slightly speed up http-parser and http-header-writing. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=32850

Patch Set 3 : Limit status code length. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -39 lines)			Patch
M	sdk/lib/io/http_headers.dart	View		1 chunk	+13 lines, -7 lines	0 comments	Download
M	sdk/lib/io/http_impl.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/http_parser.dart	View	1 2	15 chunks	+40 lines, -31 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Additional comment. https://codereview.chromium.org/173683002/diff/20001/sdk/lib/io/http_parser.dart File sdk/lib/io/http_parser.dart (right): https://codereview.chromium.org/173683002/diff/20001/sdk/lib/io/http_parser.dart#newcode511 sdk/lib/io/http_parser.dart:511: _statusCode = _statusCode * 10 + byte ...

6 years, 10 months ago (2014-02-20 14:12:18 UTC) #3

Anders Johnsen

https://codereview.chromium.org/173683002/diff/20001/sdk/lib/io/http_parser.dart File sdk/lib/io/http_parser.dart (right): https://codereview.chromium.org/173683002/diff/20001/sdk/lib/io/http_parser.dart#newcode511 sdk/lib/io/http_parser.dart:511: _statusCode = _statusCode * 10 + byte - 0x30; ...

6 years, 10 months ago (2014-02-20 14:46:53 UTC) #4

Anders Johnsen

6 years, 10 months ago (2014-02-20 14:47:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r32850 (presubmit successful).

Expand Messages | Collapse Messages