Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 173633002: Don't try to call read, if len i 0. (Closed)

Created:
6 years, 10 months ago by Anders Johnsen
Modified:
6 years, 10 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Don't try to call read, if len i 0. Also fix a Socket_Read to handle -1 from read. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=32849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M runtime/bin/socket.cc View 1 chunk +9 lines, -11 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 10 months ago (2014-02-20 09:47:23 UTC) #1
Søren Gjesse
lgtm
6 years, 10 months ago (2014-02-20 11:58:21 UTC) #2
Anders Johnsen
6 years, 10 months ago (2014-02-20 12:23:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32849 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698