Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1734773002: Copy the web socket stuff from http_parser. (Closed)

Created:
4 years, 9 months ago by nweiz
Modified:
4 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web_socket_channel.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Copy the web socket stuff from http_parser. I'm moving this to a separate package where it makes sense to also have implementations of WebSocketChannel that wrap the dart:io and dart:html WebSocket classes. This will make it a lot easier for users to use libraries (such as json_rpc_2) that require StreamChannels with well-behaved socket channels. R=kevmoo@google.com Committed: https://github.com/dart-lang/web_socket_channel/commit/45aef9e61a675acec65a2e6da3bc6e44fe095cbf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1517 lines, -0 lines) Patch
A codereview.settings View 1 chunk +3 lines, -0 lines 0 comments Download
A lib/src/channel.dart View 1 chunk +127 lines, -0 lines 0 comments Download
A lib/src/copy/bytes_builder.dart View 1 chunk +215 lines, -0 lines 0 comments Download
A lib/src/copy/io_sink.dart View 1 chunk +145 lines, -0 lines 0 comments Download
A lib/src/copy/web_socket.dart View 1 chunk +40 lines, -0 lines 0 comments Download
A lib/src/copy/web_socket_impl.dart View 1 chunk +860 lines, -0 lines 0 comments Download
A lib/src/exception.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A lib/web_socket_channel.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +5 lines, -0 lines 0 comments Download
A test/web_socket_test.dart View 1 chunk +97 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
4 years, 9 months ago (2016-02-24 19:33:07 UTC) #1
kevmoo
Are we going to an export/deprecate dance in http_parser as well? LGTM
4 years, 9 months ago (2016-02-24 21:56:47 UTC) #2
nweiz
On 2016/02/24 21:56:47, kevmoo wrote: > Are we going to an export/deprecate dance in http_parser ...
4 years, 9 months ago (2016-02-24 23:49:50 UTC) #3
nweiz
4 years, 9 months ago (2016-02-25 23:53:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
45aef9e61a675acec65a2e6da3bc6e44fe095cbf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698