Issue 17346002: Fix for issue 11262.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17346002: Fix for issue 11262. (Closed)

Created:
7 years, 6 months ago by siva

Modified:
7 years, 6 months ago

Reviewers:
vsm, regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for issue 11262. - Add Dart_InstanceGetType - Wire Dart_New, Dart_Invoke and Dart_[G|S]etField to use types

Patch Set 3 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+331 lines, -252 lines)			Patch
M	runtime/include/dart_api.h	View	11 chunks	+26 lines, -14 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	14 chunks	+139 lines, -106 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	42 chunks	+166 lines, -132 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with one question https://codereview.chromium.org/17346002/diff/1/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://codereview.chromium.org/17346002/diff/1/runtime/include/dart_api.h#newcode2064 runtime/include/dart_api.h:2064: * \param type_name The name ...

7 years, 6 months ago (2013-06-18 08:14:24 UTC) #3

siva

7 years, 6 months ago (2013-06-18 17:23:58 UTC) #4

https://codereview.chromium.org/17346002/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/17346002/diff/1/runtime/include/dart_api.h#ne...
runtime/include/dart_api.h:2064: * \param type_name The name of the type.
Yes, I cut and paste the prototype from the first bug report and forgot about
the second update I had done to the bug report.

On 2013/06/18 08:14:24, regis wrote:
> Didn't we decide to call this parameter class_name?

https://codereview.chromium.org/17346002/diff/1/runtime/include/dart_api.h#ne...
runtime/include/dart_api.h:2074: Dart_Handle type_name,
On 2013/06/18 08:14:24, regis wrote:
> class_name?

Done.

Expand Messages | Collapse Messages

Issue 17346002: Fix for issue 11262. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages