Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 17334003: Do not treat elements of lists allocated through new List() and new List.filled() as potentially nu… (Closed)

Created:
7 years, 6 months ago by ngeoffray
Modified:
7 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not treat elements of lists allocated through new List() and new List.filled() as potentially null. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=24176

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -36 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/container_tracer.dart View 3 chunks +27 lines, -12 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/list_tracer_test.dart View 1 4 chunks +32 lines, -22 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 6 months ago (2013-06-19 09:26:53 UTC) #1
kasperl
LGTM!
7 years, 6 months ago (2013-06-19 09:30:03 UTC) #2
ngeoffray
7 years, 6 months ago (2013-06-19 09:35:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r24176 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698