Issue 17317002: Convert isX() methods to isX getter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17317002: Convert isX() methods to isX getter. (Closed)

Created:
7 years, 6 months ago by scheglov

Modified:
7 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Convert isX() methods to isX getter. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24115

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+651 lines, -603 lines)			Patch
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java	View	3 chunks	+19 lines, -4 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/PropertySemanticProcessorTest.java	View	2 chunks	+37 lines, -1 line	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/ast.dart	View	40 chunks	+57 lines, -57 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/constant.dart	View	33 chunks	+57 lines, -57 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/element.dart	View	53 chunks	+88 lines, -88 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/engine.dart	View	10 chunks	+34 lines, -34 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/html.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/instrumentation.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/parser.dart	View	28 chunks	+34 lines, -34 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/resolver.dart	View	94 chunks	+126 lines, -126 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/scanner.dart	View	5 chunks	+16 lines, -16 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/sdk.dart	View	2 chunks	+12 lines, -12 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/sdk_io.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/source.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/source_io.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/utilities_dart.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer_experimental/test/generated/element_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer_experimental/test/generated/parser_test.dart	View	21 chunks	+76 lines, -79 lines	0 comments	Download
M	pkg/analyzer_experimental/test/generated/resolver_test.dart	View	8 chunks	+28 lines, -28 lines	0 comments	Download
M	pkg/analyzer_experimental/test/generated/scanner_test.dart	View	1 chunk	+59 lines, -59 lines	0 comments	Download
M	pkg/analyzer_experimental/test/generated/test_support.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

7 years, 6 months ago (2013-06-17 23:02:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r24115 (presubmit successful).

Expand Messages | Collapse Messages