Add a hack to globally register a platform plugin.

Add a hack to globally register a platform plugin.

[nweiz, 2016-02-23 22:22:38]

nweiz@google.com changed reviewers:
+ abarth@google.com, kevmoo@google.com

[kevmoo, 2016-02-23 22:54:50]

LGTM - with question

https://codereview.chromium.org/1731503002/diff/1/lib/src/runner/plugin/hack_...
File lib/src/runner/plugin/hack_register_platform.dart (right):

https://codereview.chromium.org/1731503002/diff/1/lib/src/runner/plugin/hack_...
lib/src/runner/plugin/hack_register_platform.dart:30: void
registerPlatformPlugin(Iterable<TestPlatform> platforms, getPlugin()) {
Feels weird that getPlugin() doesn't take in an arg – but I may be missing
something

[nweiz, 2016-02-24 00:21:22]

https://codereview.chromium.org/1731503002/diff/1/lib/src/runner/plugin/hack_...
File lib/src/runner/plugin/hack_register_platform.dart (right):

https://codereview.chromium.org/1731503002/diff/1/lib/src/runner/plugin/hack_...
lib/src/runner/plugin/hack_register_platform.dart:30: void
registerPlatformPlugin(Iterable<TestPlatform> platforms, getPlugin()) {
On 2016/02/23 22:54:50, kevmoo wrote:
> Feels weird that getPlugin() doesn't take in an arg –&nbsp;but I may be
missing
> something

What arg do you expect it to take in?

[kevmoo, 2016-02-24 00:28:54]

https://codereview.chromium.org/1731503002/diff/1/lib/src/runner/plugin/hack_...
File lib/src/runner/plugin/hack_register_platform.dart (right):

https://codereview.chromium.org/1731503002/diff/1/lib/src/runner/plugin/hack_...
lib/src/runner/plugin/hack_register_platform.dart:30: void
registerPlatformPlugin(Iterable<TestPlatform> platforms, getPlugin()) {
On 2016/02/24 00:21:22, nweiz wrote:
> On 2016/02/23 22:54:50, kevmoo wrote:
> > Feels weird that getPlugin() doesn't take in an arg –&nbsp;but I may be
> missing
> > something
> 
> What arg do you expect it to take in?

The platform? – although I guess you can call this many times.

Never mind. :-)

[abarth, 2016-02-25 22:23:26]

lgtm

[nweiz, 2016-02-25 23:38:19]

Landed:
https://github.com/dart-lang/test/commit/ecd14987e1b03961d8e436a601a715254084...