Add unmodifiable_collection package.

Add unmodifiable_collection package.

The package contains unmodifiable views for List, Map and Set, as well as
a fixed-length view for List.

The views simply wrap the original collection and forward all allowed calls
to it, but throws if calling a modifying method.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24229

[floitsch, 2013-06-20 13:07:33]

LGTM.

https://codereview.chromium.org/17315017/diff/1/pkg/unmodifiable_collection/l...
File pkg/unmodifiable_collection/lib/unmodifiable_collection.dart (right):

https://codereview.chromium.org/17315017/diff/1/pkg/unmodifiable_collection/l...
pkg/unmodifiable_collection/lib/unmodifiable_collection.dart:18: class
UnmodifiableListView<E> extends _IterableView<E>
Just reexport the one from dart:collection.

https://codereview.chromium.org/17315017/diff/1/pkg/unmodifiable_collection/t...
File pkg/unmodifiable_collection/test/unmodifiable_collection_test.dart (right):

https://codereview.chromium.org/17315017/diff/1/pkg/unmodifiable_collection/t...
pkg/unmodifiable_collection/test/unmodifiable_collection_test.dart:234:
expect(wrapped.skipWhile((x) => true), equals(original.skipWhile((x) => true)));
long line.

https://codereview.chromium.org/17315017/diff/1/pkg/unmodifiable_collection/t...
pkg/unmodifiable_collection/test/unmodifiable_collection_test.dart:307:
expect(wrapped.getRange(len >> 1, len),
len ~/ 2

https://codereview.chromium.org/17315017/diff/1/pkg/unmodifiable_collection/t...
pkg/unmodifiable_collection/test/unmodifiable_collection_test.dart:316:
expect(wrapped.sublist(len >> 1), equals(original.sublist(len >> 1)));
ditto.

[Lasse Reichstein Nielsen, 2013-06-20 14:04:19]

https://codereview.chromium.org/17315017/diff/1/pkg/unmodifiable_collection/l...
File pkg/unmodifiable_collection/lib/unmodifiable_collection.dart (right):

https://codereview.chromium.org/17315017/diff/1/pkg/unmodifiable_collection/l...
pkg/unmodifiable_collection/lib/unmodifiable_collection.dart:18: class
UnmodifiableListView<E> extends _IterableView<E>
On 2013/06/20 13:07:33, floitsch wrote:
> Just reexport the one from dart:collection.

Done.

https://codereview.chromium.org/17315017/diff/1/pkg/unmodifiable_collection/t...
File pkg/unmodifiable_collection/test/unmodifiable_collection_test.dart (right):

https://codereview.chromium.org/17315017/diff/1/pkg/unmodifiable_collection/t...
pkg/unmodifiable_collection/test/unmodifiable_collection_test.dart:234:
expect(wrapped.skipWhile((x) => true), equals(original.skipWhile((x) => true)));
On 2013/06/20 13:07:33, floitsch wrote:
> long line.

Done.

https://codereview.chromium.org/17315017/diff/1/pkg/unmodifiable_collection/t...
pkg/unmodifiable_collection/test/unmodifiable_collection_test.dart:307:
expect(wrapped.getRange(len >> 1, len),
On 2013/06/20 13:07:33, floitsch wrote:
> len ~/ 2

Done.

https://codereview.chromium.org/17315017/diff/1/pkg/unmodifiable_collection/t...
pkg/unmodifiable_collection/test/unmodifiable_collection_test.dart:316:
expect(wrapped.sublist(len >> 1), equals(original.sublist(len >> 1)));
On 2013/06/20 13:07:33, floitsch wrote:
> ditto.

Done.

[Lasse Reichstein Nielsen, 2013-06-20 14:06:50]

Committed patchset #2 manually as r24229 (presubmit successful).

[Søren Gjesse, 2013-07-31 12:33:07]

Drive by after seeing this new package.

https://codereview.chromium.org/17315017/diff/4001/pkg/unmodifiable_collectio...
File pkg/unmodifiable_collection/lib/unmodifiable_collection.dart (right):

https://codereview.chromium.org/17315017/diff/4001/pkg/unmodifiable_collectio...
pkg/unmodifiable_collection/lib/unmodifiable_collection.dart:136: class
UnmodifiableMapView<K, V> implements Map<K, V> {
Could we consider having this in the dart:collection library like we already
have UnmodifiableListView? I already have this code in uri.dart (class
_UnmodifiableMap), so size-wise it should not be an issue. Currently I am adding
another copy to the dart:io library.

[ahe, 2013-08-07 15:57:59]

https://codereview.chromium.org/17315017/diff/4001/pkg/unmodifiable_collectio...
File pkg/unmodifiable_collection/lib/unmodifiable_collection.dart (right):

https://codereview.chromium.org/17315017/diff/4001/pkg/unmodifiable_collectio...
pkg/unmodifiable_collection/lib/unmodifiable_collection.dart:136: class
UnmodifiableMapView<K, V> implements Map<K, V> {
On 2013/07/31 12:33:08, Søren Gjesse wrote:
> Could we consider having this in the dart:collection library like we already
> have UnmodifiableListView? I already have this code in uri.dart (class
> _UnmodifiableMap), so size-wise it should not be an issue. Currently I am
adding
> another copy to the dart:io library.

+1

I need it for dart:mirrors.

[floitsch, 2013-11-05 01:23:24]

https://codereview.chromium.org/17315017/diff/4001/pkg/unmodifiable_collectio...
File pkg/unmodifiable_collection/lib/unmodifiable_collection.dart (right):

https://codereview.chromium.org/17315017/diff/4001/pkg/unmodifiable_collectio...
pkg/unmodifiable_collection/lib/unmodifiable_collection.dart:136: class
UnmodifiableMapView<K, V> implements Map<K, V> {
On 2013/08/07 15:57:59, ahe wrote:
> On 2013/07/31 12:33:08, Søren Gjesse wrote:
> > Could we consider having this in the dart:collection library like we already
> > have UnmodifiableListView? I already have this code in uri.dart (class
> > _UnmodifiableMap), so size-wise it should not be an issue. Currently I am
> adding
> > another copy to the dart:io library.
> 
> +1
> 
> I need it for dart:mirrors.

I discussed this with Lasse, and we will probably merge the package into the
collection library.

[Søren Gjesse, 2013-11-05 06:54:15]

On 2013/11/05 01:23:24, floitsch wrote:
>
https://codereview.chromium.org/17315017/diff/4001/pkg/unmodifiable_collectio...
> File pkg/unmodifiable_collection/lib/unmodifiable_collection.dart (right):
> 
>
https://codereview.chromium.org/17315017/diff/4001/pkg/unmodifiable_collectio...
> pkg/unmodifiable_collection/lib/unmodifiable_collection.dart:136: class
> UnmodifiableMapView<K, V> implements Map<K, V> {
> On 2013/08/07 15:57:59, ahe wrote:
> > On 2013/07/31 12:33:08, Søren Gjesse wrote:
> > > Could we consider having this in the dart:collection library like we
already
> > > have UnmodifiableListView? I already have this code in uri.dart (class
> > > _UnmodifiableMap), so size-wise it should not be an issue. Currently I am
> > adding
> > > another copy to the dart:io library.
> > 
> > +1
> > 
> > I need it for dart:mirrors.
> 
> I discussed this with Lasse, and we will probably merge the package into the
> collection library.

Sounds good.