Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 17315006: Scale the OSR optimization threshold by loop nesting depth. (Closed)

Created:
7 years, 6 months ago by Kevin Millikin (Google)
Modified:
7 years, 6 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Scale the OSR optimization threshold by loop nesting depth. For on-stack replacement (OSR), code quality is better if we optimize at the outermost hot loop. Track loop nesting depth and scale the threshold based on the loop depth to prefer outer loops over inner ones. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=24175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -15 lines) Patch
M runtime/vm/code_generator.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 11 chunks +12 lines, -4 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +5 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
7 years, 6 months ago (2013-06-19 08:44:02 UTC) #1
Florian Schneider
lgtm
7 years, 6 months ago (2013-06-19 08:55:28 UTC) #2
Kevin Millikin (Google)
7 years, 6 months ago (2013-06-19 09:21:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24175 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698