Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1544)

Issue 1731483002: Add iOS as an operating system. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +6 lines, -0 lines 0 comments Download
M README.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/backend/operating_system.dart View 3 chunks +8 lines, -1 line 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 10 months ago (2016-02-23 22:11:04 UTC) #1
kevmoo
LGTM - add -dev to pubspec?
4 years, 10 months ago (2016-02-23 22:18:42 UTC) #2
nweiz
On 2016/02/23 22:18:42, kevmoo wrote: > LGTM - add -dev to pubspec? Done.
4 years, 10 months ago (2016-02-23 22:22:59 UTC) #3
nweiz
Code review changes
4 years, 10 months ago (2016-02-23 22:23:22 UTC) #4
nweiz
4 years, 10 months ago (2016-02-23 22:23:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ea098667002f8b9ce0b37096b62c580bd6e54b04 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698