Fix crash in OSR with --optimization-counter-threshold=-1: do not check for OSR if the optimizaiton…

Fix crash in OSR with --optimization-counter-threshold=-1: do not check for OSR if the optimizaiton is disabled.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24112

[siva, 2013-06-17 21:31:40]

lgtm

https://codereview.chromium.org/17311002/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/17311002/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_ia32.cc:2151: !compiler->is_optimizing() &&
in_loop()) {
Would it make sense to have a CanOSRFunction() helper which
covers these conditions, the code would become

if (compiler->CanOSRFunction() && in_loop()) {
...
}

[srdjan, 2013-06-17 21:46:14]

https://codereview.chromium.org/17311002/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/17311002/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_ia32.cc:2151: !compiler->is_optimizing() &&
in_loop()) {
On 2013/06/17 21:31:40, siva wrote:
> Would it make sense to have a CanOSRFunction() helper which
> covers these conditions, the code would become
> 
> if (compiler->CanOSRFunction() && in_loop()) {
> ...
> }

Done

[srdjan, 2013-06-17 22:36:36]

Committed patchset #2 manually as r24112 (presubmit successful).