Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 17302007: Add timing information for the individual steps of a failing test. (Closed)

Created:
7 years, 6 months ago by ricow1
Modified:
7 years, 6 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add timing information for the individual steps of a failing test. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=24213

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/testing/dart/test_progress.dart View 1 chunk +6 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
7 years, 6 months ago (2013-06-20 06:33:59 UTC) #1
kustermann
https://codereview.chromium.org/17302007/diff/1/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (right): https://codereview.chromium.org/17302007/diff/1/tools/testing/dart/test_progress.dart#newcode134 tools/testing/dart/test_progress.dart:134: if (commandOutput != null) { I think we should ...
7 years, 6 months ago (2013-06-20 08:05:28 UTC) #2
ricow1
https://codereview.chromium.org/17302007/diff/1/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (right): https://codereview.chromium.org/17302007/diff/1/tools/testing/dart/test_progress.dart#newcode134 tools/testing/dart/test_progress.dart:134: if (commandOutput != null) { On 2013/06/20 08:05:28, kustermann ...
7 years, 6 months ago (2013-06-20 08:23:10 UTC) #3
kustermann
lgtm
7 years, 6 months ago (2013-06-20 09:01:51 UTC) #4
ricow1
7 years, 6 months ago (2013-06-20 09:03:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r24213 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698