Issue 17288009: Removes references to LIB_DIR from gyp files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17288009: Removes references to LIB_DIR from gyp files. (Closed)

Created:
7 years, 6 months ago by zra

Modified:
7 years, 6 months ago

Reviewers:
ricow1, kustermann, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Removes references to LIB_DIR from gyp files. This eliminates the cirular dependency warnings from make. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=24206

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -70 lines)			Patch
M	runtime/bin/bin.gypi	View	11 chunks	+14 lines, -23 lines	0 comments	Download
M	runtime/dart-runtime.gyp	View	3 chunks	+3 lines, -7 lines	0 comments	Download
M	runtime/vm/vm.gypi	View	22 chunks	+40 lines, -40 lines	0 comments	Download

Total messages: 4 (0 generated)

zra

It looks to me like the generated source files are architecture generic, so there is ...

7 years, 6 months ago (2013-06-19 17:19:36 UTC) #1

Ivan Posva

LGTM Thanks to Martin and Zach for getting this analyzed and resolved! -Ivan

7 years, 6 months ago (2013-06-19 22:13:52 UTC) #2

zra

Committed patchset #1 manually as r24206 (presubmit successful).

7 years, 6 months ago (2013-06-19 22:34:01 UTC) #3

Message was sent while issue was closed.

lgtm