Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 17288005: Try to avoid checks for lazy initialization when recompiling. (Closed)

Created:
7 years, 6 months ago by Kevin Millikin (Google)
Modified:
7 years, 6 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, hausner
Visibility:
Public.

Description

Try to avoid checks for lazy initialization when recompiling. When recompiling implicit static getters, it can happen that the field is already initialized. In this case parse the getter to a field load instead of a pair of sentinel checks and initialization code. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=24122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M runtime/vm/intermediate_language_arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
7 years, 6 months ago (2013-06-17 18:18:42 UTC) #1
srdjan
LGTM
7 years, 6 months ago (2013-06-17 18:31:32 UTC) #2
Kevin Millikin (Google)
7 years, 6 months ago (2013-06-18 06:55:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24122 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698