Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 172873002: pkg/docgen: putting test code in file system (Closed)

Created:
6 years, 10 months ago by kevmoo
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/docgen: putting test code in file system R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=32821

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : fix warnings #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -192 lines) Patch
M pkg/docgen/test/generate_json_test.dart View 3 chunks +5 lines, -89 lines 0 comments Download
A pkg/docgen/test/multi_library_code/lib/temp.dart View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
A pkg/docgen/test/multi_library_code/lib/temp2.dart View 1 chunk +36 lines, -0 lines 0 comments Download
A pkg/docgen/test/multi_library_code/lib/temp3.dart View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/docgen/test/multi_library_test.dart View 1 2 chunks +11 lines, -100 lines 0 comments Download
A pkg/docgen/test/util.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/pkg.status View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kevmoo
6 years, 10 months ago (2014-02-19 20:45:14 UTC) #1
Alan Knight
lgtm
6 years, 10 months ago (2014-02-19 21:07:28 UTC) #2
kevmoo
6 years, 10 months ago (2014-02-19 21:11:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r32821 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698