Issue 17283006: Fix a small bug in trace printing for discovered loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17283006: Fix a small bug in trace printing for discovered loops. (Closed)

Created:
7 years, 6 months ago by Kevin Millikin (Google)

Modified:
7 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix a small bug in trace printing for discovered loops. Loop blocks were printed with their preorder number, which is hard to correlate to the graph. Use the block id instead. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=24184

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -7 lines)			Patch
M	runtime/vm/flow_graph.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Kevin Millikin (Google)

7 years, 6 months ago (2013-06-19 13:56:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r24184 (presubmit successful).