Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 172823002: Speeding up go.sh (Closed)

Created:
6 years, 10 months ago by blois
Modified:
6 years, 10 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Speeding up go.sh Primary issue was resolving the media events (over and over and over). Tried to cache all resolved events but ran into complications with dart2js suppressions. Takes it down to ~12-15s on my machine. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=32812

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/dom/scripts/htmleventgenerator.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
6 years, 10 months ago (2014-02-19 19:30:34 UTC) #1
vsm
lgtm
6 years, 10 months ago (2014-02-19 19:33:35 UTC) #2
blois
6 years, 10 months ago (2014-02-19 19:35:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32812 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698