Issue 17281002: Make String.startsWith take an optional start index.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17281002: Make String.startsWith take an optional start index. (Closed)

Created:
7 years, 6 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 6 months ago

Reviewers:
floitsch, srdjan, ngeoffray

CC:
reviews_dartlang.org, srdjan, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make String.startsWith take an optional start index. R=floitsch@google.com, ngeoffray@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=24142

Patch Set 2 : Address review comments. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -8 lines)			Patch
M	runtime/lib/string_patch.dart	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_string.dart	View		1 chunk	+8 lines, -4 lines	0 comments	Download
M	sdk/lib/core/string.dart	View	1	1 chunk	+11 lines, -1 line	0 comments	Download
M	tests/corelib/string_test.dart	View	1	2 chunks	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/17281002/diff/1/sdk/lib/core/string.dart File sdk/lib/core/string.dart (right): https://codereview.chromium.org/17281002/diff/1/sdk/lib/core/string.dart#newcode110 sdk/lib/core/string.dart:110: * If [index] is provided, instead check if ...

7 years, 6 months ago (2013-06-17 16:07:15 UTC) #4

Lasse Reichstein Nielsen

7 years, 6 months ago (2013-06-18 13:59:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r24142 (presubmit successful).

Expand Messages | Collapse Messages

Issue 17281002: Make String.startsWith take an optional start index. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comments. #

Messages