Issue 172743003: pkg/docgen: basic test of json output

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 172743003: pkg/docgen: basic test of json output (Closed)

Created:
6 years, 10 months ago by kevmoo

Modified:
6 years, 10 months ago

Reviewers:
Alan Knight, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/docgen: basic test of json output align API with bin: generate json by default (not yaml) added type to docgen 'out' argument R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=32806

Patch Set 1 #

Total comments: 1

Patch Set 2 : nits #

Patch Set 3 : more nits #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -2 lines)			Patch
M	pkg/docgen/lib/docgen.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/docgen/pubspec.yaml	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	pkg/docgen/test/generate_json_test.dart	View	1 2	1 chunk	+145 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Alan Knight

lgtm, with nit https://codereview.chromium.org/172743003/diff/1/pkg/docgen/test/generate_json_test.dart File pkg/docgen/test/generate_json_test.dart (right): https://codereview.chromium.org/172743003/diff/1/pkg/docgen/test/generate_json_test.dart#newcode68 pkg/docgen/test/generate_json_test.dart:68: const String DART_LIBRARY_1 = ''' Is ...

6 years, 10 months ago (2014-02-19 18:50:49 UTC) #2

kevmoo

6 years, 10 months ago (2014-02-19 19:05:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r32806 (presubmit successful).

Expand Messages | Collapse Messages