Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 17271005: Create a proper abstraction for field constraints, and handle inrisified selectors with it. This al… (Closed)

Created:
7 years, 6 months ago by ngeoffray
Modified:
7 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Create a proper abstraction for field constraints, and handle inrisified selectors with it. This allows to infer that with this.foo = 0 and this.foo++, foo is of type int, and not just number. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=24131

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -21 lines) Patch
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 1 13 chunks +35 lines, -19 lines 0 comments Download
M tests/compiler/dart2js/field_type_simple_inferer_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
This fixes part 2 of https://code.google.com/p/dart/issues/detail?id=10927.
7 years, 6 months ago (2013-06-18 10:29:32 UTC) #1
kasperl
LGTM!
7 years, 6 months ago (2013-06-18 10:52:15 UTC) #2
ngeoffray
7 years, 6 months ago (2013-06-18 10:59:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r24131 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698