Issue 17265003: Avoid double-// on directory listing.

Issue 17265003: Avoid double-// on directory listing. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen

Modified:
7 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid double-// on directory listing. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24123

Patch Set 3 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	sdk/lib/io/directory_impl.dart	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
	M	tests/standalone/io/directory_list_pause_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Add test? https://codereview.chromium.org/17265003/diff/1/sdk/lib/io/directory_impl.dart File sdk/lib/io/directory_impl.dart (right): https://codereview.chromium.org/17265003/diff/1/sdk/lib/io/directory_impl.dart#newcode240 sdk/lib/io/directory_impl.dart:240: static String _getListPath(String path) { _removeTrailingPathSeparators?

7 years, 6 months ago (2013-06-17 15:01:55 UTC) #2

Søren Gjesse

lgtm https://codereview.chromium.org/17265003/diff/6001/sdk/lib/io/directory_impl.dart File sdk/lib/io/directory_impl.dart (right): https://codereview.chromium.org/17265003/diff/6001/sdk/lib/io/directory_impl.dart#newcode243 sdk/lib/io/directory_impl.dart:243: if (Platform.operatingSystem == 'windows') { Won't this loop ...

7 years, 6 months ago (2013-06-18 06:54:09 UTC) #5

Anders Johnsen

https://codereview.chromium.org/17265003/diff/6001/sdk/lib/io/directory_impl.dart File sdk/lib/io/directory_impl.dart (right): https://codereview.chromium.org/17265003/diff/6001/sdk/lib/io/directory_impl.dart#newcode243 sdk/lib/io/directory_impl.dart:243: if (Platform.operatingSystem == 'windows') { On 2013/06/18 06:54:09, Søren ...

7 years, 6 months ago (2013-06-18 06:55:26 UTC) #6

Anders Johnsen

7 years, 6 months ago (2013-06-18 06:56:26 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as r24123 (presubmit successful).

Expand Messages | Collapse Messages