Issue 172633006: Revert "Revert "Adding package:code_transformers for unifying common transformers code""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 172633006: Revert "Revert "Adding package:code_transformers for unifying common transformers code"" (Closed)

Created:
6 years, 10 months ago by blois

Modified:
6 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Revert "Adding package:code_transformers for unifying common transformers code"" This is a re-submission of adding code_transformers with a fix for resolving the sdk directory. The resolution was failing when executing tests with the --use-sdk flag. BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=32908

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1094 lines, -32 lines)			Patch
A +	pkg/code_transformers/AUTHORS	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/code_transformers/LICENSE	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/code_transformers/PATENTS	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/code_transformers/lib/resolver.dart	View		1 chunk	+5 lines, -4 lines	0 comments	Download
A	pkg/code_transformers/lib/src/dart_sdk.dart	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download
A	pkg/code_transformers/lib/src/resolver.dart	View		1 chunk	+81 lines, -0 lines	0 comments	Download
A	pkg/code_transformers/lib/src/resolver_impl.dart	View		1 chunk	+545 lines, -0 lines	0 comments	Download
A	pkg/code_transformers/lib/src/resolver_transformer.dart	View		1 chunk	+55 lines, -0 lines	0 comments	Download
A +	pkg/code_transformers/lib/src/test_harness.dart	View		4 chunks	+10 lines, -31 lines	0 comments	Download
A	pkg/code_transformers/lib/tests.dart	View		1 chunk	+40 lines, -0 lines	0 comments	Download
A	pkg/code_transformers/pubspec.yaml	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A	pkg/code_transformers/test/resolver_test.dart	View		1 chunk	+304 lines, -0 lines	0 comments	Download
M	pkg/pkg.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm might be worth adding a dart_sdk_test to use it as a simple canary test ...

6 years, 10 months ago (2014-02-20 22:32:36 UTC) #2

blois

6 years, 10 months ago (2014-02-21 17:27:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r32908 (presubmit successful).

Expand Messages | Collapse Messages