Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 17261011: Replace uses of Dart_GetClass with Dart_GetType and Dart_InstanceGetClass with Dart_InstanceGetType… (Closed)

Created:
7 years, 6 months ago by siva
Modified:
7 years, 6 months ago
Reviewers:
regis, Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Replace uses of Dart_GetClass with Dart_GetType and Dart_InstanceGetClass with Dart_InstanceGetType (The idea is to deprecate Dart_GetClass and Dart_InstanceGetClass from the API) R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24244

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -45 lines) Patch
M runtime/bin/dartutils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/dartutils.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M runtime/bin/directory.h View 2 chunks +9 lines, -9 lines 0 comments Download
M runtime/bin/directory.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/main.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M runtime/bin/secure_socket.cc View 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years, 6 months ago (2013-06-19 23:41:43 UTC) #1
Søren Gjesse
lgtm, thanks
7 years, 6 months ago (2013-06-20 08:29:15 UTC) #2
siva
Committed patchset #1 manually as r24244 (presubmit successful).
7 years, 6 months ago (2013-06-20 18:11:51 UTC) #3
regis
7 years, 6 months ago (2013-06-24 18:53:06 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698