Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 172493003: pkg/scheduled_test: fix example in docs to be 100% valid (Closed)

Created:
6 years, 10 months ago by kevmoo
Modified:
6 years, 10 months ago
Reviewers:
nweiz, Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/scheduled_test: fix example in docs to be 100% valid R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=32827

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/scheduled_test/lib/descriptor.dart View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
kevmoo
6 years, 10 months ago (2014-02-19 17:36:59 UTC) #1
Bob Nystrom
One nit then LGTM! https://codereview.chromium.org/172493003/diff/1/pkg/scheduled_test/lib/descriptor.dart File pkg/scheduled_test/lib/descriptor.dart (right): https://codereview.chromium.org/172493003/diff/1/pkg/scheduled_test/lib/descriptor.dart#newcode13 pkg/scheduled_test/lib/descriptor.dart:13: /// import 'dart:io'; Nit, but ...
6 years, 10 months ago (2014-02-19 18:17:28 UTC) #2
kevmoo
Trying to keep the sample as few of lines as possible. Important?
6 years, 10 months ago (2014-02-19 18:23:29 UTC) #3
Bob Nystrom
On 2014/02/19 18:23:29, kevmoo wrote: > Trying to keep the sample as few of lines ...
6 years, 10 months ago (2014-02-19 19:07:02 UTC) #4
kevmoo
https://codereview.chromium.org/172493003/diff/1/pkg/scheduled_test/lib/descriptor.dart File pkg/scheduled_test/lib/descriptor.dart (right): https://codereview.chromium.org/172493003/diff/1/pkg/scheduled_test/lib/descriptor.dart#newcode13 pkg/scheduled_test/lib/descriptor.dart:13: /// import 'dart:io'; On 2014/02/19 18:17:28, Bob Nystrom wrote: ...
6 years, 10 months ago (2014-02-19 21:53:12 UTC) #5
kevmoo
6 years, 10 months ago (2014-02-19 21:53:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r32827 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698