Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 172443002: Always present data from http through a view. (Closed)

Created:
6 years, 10 months ago by Anders Johnsen
Modified:
6 years, 10 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Always present data from http through a view. This avoids sending out different data typed, thus provoking polymorphic code. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=32793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M sdk/lib/io/http_parser.dart View 1 chunk +8 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 10 months ago (2014-02-19 14:24:23 UTC) #1
Søren Gjesse
lgtm :-/
6 years, 10 months ago (2014-02-19 14:40:30 UTC) #2
Anders Johnsen
6 years, 10 months ago (2014-02-19 14:45:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32793 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698