Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 17241002: Reuse existing test instead of duplicating code. (Closed)

Created:
7 years, 6 months ago by ahe
Modified:
7 years, 6 months ago
Reviewers:
gbracha, ngeoffray
CC:
reviews_dartlang.org, gbracha
Visibility:
Public.

Description

Reuse existing test instead of duplicating code. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=24080

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -31 lines) Patch
M dart/tests/lib/mirrors/library_metadata_test.dart View 1 chunk +2 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
7 years, 6 months ago (2013-06-17 09:08:24 UTC) #1
ngeoffray
LGTM
7 years, 6 months ago (2013-06-17 09:15:53 UTC) #2
ahe
Committed patchset #1 manually as r24080 (presubmit successful).
7 years, 6 months ago (2013-06-17 09:18:35 UTC) #3
gbracha
7 years, 6 months ago (2013-06-17 21:55:21 UTC) #4
Message was sent while issue was closed.
The thought of doing this had occurred to me as well; good!

Powered by Google App Engine
This is Rietveld 408576698