Issue 17232004: Fix bug in register allocation at catch entry blocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17232004: Fix bug in register allocation at catch entry blocks. (Closed)

Created:
7 years, 6 months ago by Florian Schneider

Modified:
7 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug in register allocation at catch entry blocks. The registers used to pass the exception and the stacktrace values need to be blocked at catch block entry until after the CatchEntry instruction which stores them into local variables. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=24105

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	runtime/vm/flow_graph_allocator.cc	View		2 chunks	+15 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/17232004/diff/1/runtime/vm/flow_graph_allocator.cc File runtime/vm/flow_graph_allocator.cc (right): https://codereview.chromium.org/17232004/diff/1/runtime/vm/flow_graph_allocator.cc#newcode529 runtime/vm/flow_graph_allocator.cc:529: ToInstructionEnd(NextInstructionPos(start))); Assert that the next instruction is actually ...

7 years, 6 months ago (2013-06-17 15:11:39 UTC) #2

Florian Schneider

Committed patchset #1 manually as r24105 (presubmit successful).

7 years, 6 months ago (2013-06-17 17:35:05 UTC) #3

Florian Schneider

7 years, 6 months ago (2013-06-17 17:35:35 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/17232004/diff/1/runtime/vm/flow_graph_allocat...
File runtime/vm/flow_graph_allocator.cc (right):

https://codereview.chromium.org/17232004/diff/1/runtime/vm/flow_graph_allocat...
runtime/vm/flow_graph_allocator.cc:529:
ToInstructionEnd(NextInstructionPos(start)));
On 2013/06/17 15:11:39, Vyacheslav Egorov (Google) wrote:
> Assert that the next instruction is actually CatchEntryInstr

Done.

Expand Messages | Collapse Messages