Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1722603005: Make SourceSpanException.source a getter (Closed)

Created:
4 years, 10 months ago by vsm
Modified:
4 years, 10 months ago
Reviewers:
Bob Nystrom, nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/source_span.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M lib/src/span_exception.dart View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 10 months ago (2016-02-23 00:08:49 UTC) #3
Bob Nystrom
LGTM.
4 years, 10 months ago (2016-02-23 00:45:10 UTC) #4
vsm
4 years, 10 months ago (2016-02-23 13:47:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
32de304c1a0891941e2fdcab283abde54e748340 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698