Issue 17224002: Make version generation functionallity work on non english locale.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17224002: Make version generation functionallity work on non english locale. (Closed)

Created:
7 years, 6 months ago by ricow1

Modified:
7 years, 6 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Make version generation functionallity work on non english locale. Landing patch supplied by David Gomez - see http://dartbug.com/11119 R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=24072

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	AUTHORS	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	dart/tools/utils.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kustermann

https://codereview.chromium.org/17224002/diff/1/dart/tools/utils.py File dart/tools/utils.py (right): https://codereview.chromium.org/17224002/diff/1/dart/tools/utils.py#newcode243 dart/tools/utils.py:243: stderr = subprocess.STDOUT, shell=IsWindows(), env = {'LC_MESSAGES' : 'en_GB'}) ...

7 years, 6 months ago (2013-06-17 06:38:56 UTC) #2

ricow1

7 years, 6 months ago (2013-06-17 06:40:19 UTC) #3

ricow1

7 years, 6 months ago (2013-06-17 06:42:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r24072 (presubmit successful).

Expand Messages | Collapse Messages

Issue 17224002: Make version generation functionallity work on non english locale. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages