Issue 17222002: Mark lib/mirrors/library_metadata_test as passing on dart2js csp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17222002: Mark lib/mirrors/library_metadata_test as passing on dart2js csp. (Closed)

Created:
7 years, 6 months ago by ricow1

Modified:
7 years, 6 months ago

Reviewers:
ahe, kasperl, kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Mark lib/mirrors/library_metadata_test as passing on dart2js csp. I don't think the bug to which this suppression was assigned is correct. Additionally, the suppression on the next line for mirrors/metadata_test seems to be wrongly clasified as a vm bug as well (or I am wrong and this is actually a vm bug, but it does not seem like it). R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=24073

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	tests/lib/lib.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ricow1

Committed patchset #1 manually as r24073 (presubmit successful).

7 years, 6 months ago (2013-06-17 06:50:15 UTC) #3

ahe

7 years, 6 months ago (2013-06-17 08:55:31 UTC) #5

Message was sent while issue was closed.

LGTM, updated the bug number in https://codereview.chromium.org/17239003

Expand Messages | Collapse Messages