Issue 172153007: Don't leak file names in Windows File::Stat().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 172153007: Don't leak file names in Windows File::Stat(). (Closed)

Created:
6 years, 10 months ago by Bob Nystrom

Modified:
6 years, 10 months ago

Reviewers:
Anders Johnsen, kasperl

CC:
reviews_dartlang.org, vm-dev_dartlang.org, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't leak file names in Windows File::Stat(). BUG=https://code.google.com/p/dart/issues/detail?id=13848 R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=32854

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	runtime/bin/file_win.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Pub serve on Windows currently uses polling to watch the file system. That causes its ...

6 years, 10 months ago (2014-02-20 00:23:08 UTC) #1

Anders Johnsen

LGTM, we are in the process of simplifying this windows path nightmare, should help with ...

6 years, 10 months ago (2014-02-20 09:06:50 UTC) #2

Bob Nystrom

Committed patchset #1 manually as r32854 (presubmit successful).

6 years, 10 months ago (2014-02-20 17:06:18 UTC) #4

Bob Nystrom

6 years, 10 months ago (2014-02-20 17:48:54 UTC) #5

Message was sent while issue was closed.

On 2014/02/20 09:51:12, kasperl wrote:
> Is this "merge request" worthy once it lands?

I think so. Pub serve on Windows eventually crashes with OOM without this.

Filed a request: https://code.google.com/p/dart/issues/detail?id=16988

- bob

Expand Messages | Collapse Messages