Issue 17183008: HTTP loading cleanups

Issue 17183008: HTTP loading cleanups (Closed)

Created:
7 years, 6 months ago by Cutch

Modified:
7 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

HTTP loading cleanups BUG= Committed: https://code.google.com/p/dart/source/detail?r=24165

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+173 lines, -93 lines)			Patch
M	runtime/bin/builtin.dart	View	1	5 chunks	+129 lines, -75 lines	0 comments	Download
M	runtime/bin/dartutils.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	1	8 chunks	+42 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

https://codereview.chromium.org/17183008/diff/1/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/17183008/diff/1/runtime/bin/builtin.dart#newcode131 runtime/bin/builtin.dart:131: } How about pulling this out into _enforceTrailingSlash(val)? https://codereview.chromium.org/17183008/diff/1/runtime/bin/dartutils.cc ...

7 years, 6 months ago (2013-06-18 22:24:00 UTC) #2

Cutch

https://codereview.chromium.org/17183008/diff/1/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/17183008/diff/1/runtime/bin/builtin.dart#newcode131 runtime/bin/builtin.dart:131: } On 2013/06/18 22:24:00, Ivan Posva wrote: > How ...

7 years, 6 months ago (2013-06-18 22:28:22 UTC) #3

Cutch

7 years, 6 months ago (2013-06-19 00:02:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r24165 (presubmit successful).

Expand Messages | Collapse Messages