Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 17183003: Ensure we perform the same checks for all optimizing compilations. (Closed)

Created:
7 years, 6 months ago by Kevin Millikin (Google)
Modified:
7 years, 6 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Ensure we perform the same checks for all optimizing compilations. Ensure that we perform the same checks for on-stack replacement (OSR) as for normal optimizing compilation. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=24132

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -42 lines) Patch
M runtime/vm/code_generator.cc View 4 chunks +39 lines, -34 lines 0 comments Download
M runtime/vm/compiler.cc View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
7 years, 6 months ago (2013-06-18 10:43:49 UTC) #1
Florian Schneider
LGTM.
7 years, 6 months ago (2013-06-18 11:00:23 UTC) #2
Kevin Millikin (Google)
7 years, 6 months ago (2013-06-18 11:06:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24132 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698