Fix more register allocation bugs in optimized code on ARM.

Fix more register allocation bugs in optimized code on ARM.

R=zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24191

[regis, 2013-06-19 15:10:54]

Apologies in advance if this breaks the simarm build on Mac.
Feel free to add the Mac failures (if any) back in the status files.

Thanks,
Regis

[zra, 2013-06-19 16:01:52]

lgtm.

Also, I ran this on my MBP and noted the results.

https://codereview.chromium.org/17176004/diff/1/tests/language/language.status
File tests/language/language.status (left):

https://codereview.chromium.org/17176004/diff/1/tests/language/language.statu...
tests/language/language.status:530: bit_operations_test: Crash, Fail
Crashes on mac in debug mode
Fails in release mode

https://codereview.chromium.org/17176004/diff/1/tests/language/language.statu...
tests/language/language.status:536: arithmetic_test: Pass, Crash, Fail # Fails
on Mac
Fails on mac in debug and release modes

https://codereview.chromium.org/17176004/diff/1/tests/language/language.statu...
tests/language/language.status:537: left_shift_test: Pass, Fail # Fails on Mac
Fails on mac in debug and release modes

https://codereview.chromium.org/17176004/diff/1/tests/language/language.statu...
tests/language/language.status:538: positive_bit_operations_test: Pass, Fail,
Crash # Fails and crashes on Mac
Crashes on mac in debug mode
Fails in release modes

[regis, 2013-06-19 16:20:17]

Zach,

Thanks a lot for running this cl on the Mac.
I have updated the status file accordingly.

See you next week.
Regis

https://codereview.chromium.org/17176004/diff/1/tests/language/language.status
File tests/language/language.status (left):

https://codereview.chromium.org/17176004/diff/1/tests/language/language.statu...
tests/language/language.status:530: bit_operations_test: Crash, Fail
On 2013/06/19 16:01:52, zra wrote:
> Crashes on mac in debug mode
> Fails in release mode

Done.

https://codereview.chromium.org/17176004/diff/1/tests/language/language.statu...
tests/language/language.status:536: arithmetic_test: Pass, Crash, Fail # Fails
on Mac
On 2013/06/19 16:01:52, zra wrote:
> Fails on mac in debug and release modes

Done.

https://codereview.chromium.org/17176004/diff/1/tests/language/language.statu...
tests/language/language.status:537: left_shift_test: Pass, Fail # Fails on Mac
On 2013/06/19 16:01:52, zra wrote:
> Fails on mac in debug and release modes

Done.

https://codereview.chromium.org/17176004/diff/1/tests/language/language.statu...
tests/language/language.status:538: positive_bit_operations_test: Pass, Fail,
Crash # Fails and crashes on Mac
On 2013/06/19 16:01:52, zra wrote:
> Crashes on mac in debug mode
> Fails in release modes

Done.

[regis, 2013-06-19 16:21:32]

Committed patchset #2 manually as r24191 (presubmit successful).