Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 17175007: dart:io | Add cache and getters to Platform (Closed)

Created:
7 years, 6 months ago by Søren Gjesse
Modified:
7 years, 6 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Add cache and getters to Platform Cache the static part of the Platform object. Add boolean getters for operating system. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24219

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M sdk/lib/io/platform.dart View 1 chunk +31 lines, -6 lines 0 comments Download
M tests/standalone/io/platform_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 6 months ago (2013-06-19 15:04:39 UTC) #1
Anders Johnsen
LGTM
7 years, 6 months ago (2013-06-20 11:59:54 UTC) #2
Søren Gjesse
7 years, 6 months ago (2013-06-20 12:05:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24219 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698