Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Issue 17167005: modify cache list command to show all versions of a package (Closed)

Created:
7 years, 6 months ago by keertip
Modified:
7 years, 6 months ago
Reviewers:
Bob Nystrom, nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

modify cache list command to show all versions of a package R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=24203

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M sdk/lib/_internal/pub/lib/src/command_cache.dart View 1 1 chunk +4 lines, -4 lines 1 comment Download
M sdk/lib/_internal/pub/test/pub_cache_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
keertip
7 years, 6 months ago (2013-06-19 19:52:28 UTC) #1
Bob Nystrom
https://codereview.chromium.org/17167005/diff/1/sdk/lib/_internal/pub/lib/src/command_cache.dart File sdk/lib/_internal/pub/lib/src/command_cache.dart (right): https://codereview.chromium.org/17167005/diff/1/sdk/lib/_internal/pub/lib/src/command_cache.dart#newcode46 sdk/lib/_internal/pub/lib/src/command_cache.dart:46: } var packageInfo = packagesObj.putIfAbsent(package.name, () => {}); packageInfo[package.version.toString()] ...
7 years, 6 months ago (2013-06-19 19:55:33 UTC) #2
keertip
https://codereview.chromium.org/17167005/diff/1/sdk/lib/_internal/pub/lib/src/command_cache.dart File sdk/lib/_internal/pub/lib/src/command_cache.dart (right): https://codereview.chromium.org/17167005/diff/1/sdk/lib/_internal/pub/lib/src/command_cache.dart#newcode46 sdk/lib/_internal/pub/lib/src/command_cache.dart:46: } On 2013/06/19 19:55:33, Bob Nystrom wrote: > var ...
7 years, 6 months ago (2013-06-19 20:06:01 UTC) #3
Bob Nystrom
LGTM!
7 years, 6 months ago (2013-06-19 21:00:46 UTC) #4
keertip
Committed patchset #2 manually as r24203 (presubmit successful).
7 years, 6 months ago (2013-06-19 21:03:27 UTC) #5
nweiz
7 years, 6 months ago (2013-06-19 22:14:55 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/17167005/diff/5001/sdk/lib/_internal/pub/lib/...
File sdk/lib/_internal/pub/lib/src/command_cache.dart (right):

https://codereview.chromium.org/17167005/diff/5001/sdk/lib/_internal/pub/lib/...
sdk/lib/_internal/pub/lib/src/command_cache.dart:38: 
Style nit: extra newline

Powered by Google App Engine
This is Rietveld 408576698