Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 17157009: Fix the pkg/stack_trace tests. (Closed)

Created:
7 years, 6 months ago by nweiz
Modified:
7 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix the pkg/stack_trace tests. On Windows they're now (correctly) using relative URIs as opposed to relative paths. Committed: https://code.google.com/p/dart/source/detail?r=24205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M pkg/stack_trace/lib/src/frame.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/stack_trace/test/frame_test.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M pkg/stack_trace/test/trace_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
TBR
7 years, 6 months ago (2013-06-19 22:13:13 UTC) #1
nweiz
Committed patchset #1 manually as r24205 (presubmit successful).
7 years, 6 months ago (2013-06-19 22:15:11 UTC) #2
Bob Nystrom
7 years, 6 months ago (2013-06-19 22:23:32 UTC) #3
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698