Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 171363007: set analysis server exitCode on invalid cmdline arguments (Closed)

Created:
6 years, 10 months ago by danrubel
Modified:
6 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

set analysis server exitCode on invalid cmdline arguments BUG= R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=32902

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : upload again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M pkg/analysis_server/lib/http_server.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danrubel
6 years, 10 months ago (2014-02-21 14:13:05 UTC) #1
Brian Wilkerson
LGTM
6 years, 10 months ago (2014-02-21 15:10:46 UTC) #2
danrubel
6 years, 10 months ago (2014-02-21 15:42:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r32902 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698