Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 17113002: Allow translated messages that have no matching original message (Closed)

Created:
7 years, 6 months ago by Alan Knight
Modified:
7 years, 6 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow translated messages that have no matching original message. Also clean up help text and get rid of type error for types whose name is no longer easily visible from analyzer. R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=24240

Patch Set 1 #

Patch Set 2 : Fix a typo in help text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M pkg/intl/lib/extract_messages.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/intl/lib/generate_localized.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M pkg/intl/test/message_extraction/extract_to_json.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/intl/test/message_extraction/generate_from_json.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Emily Fortuna
lgtm
7 years, 6 months ago (2013-06-20 00:19:05 UTC) #1
Alan Knight
7 years, 6 months ago (2013-06-20 17:01:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r24240 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698