Fix a bug in instance canonicalization and add debug mode checks that we are not missing any fields.

Fix a bug in instance canonicalization and add debug mode checks that we are not missing any fields.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24059

[siva, 2013-06-14 21:04:03]

https://codereview.chromium.org/17104002/diff/3001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/17104002/diff/3001/runtime/vm/object.cc#newco...
runtime/vm/object.cc:9241: const intptr_t end_field_offset = cls.instance_size()
- kWordSize;
cls.instance_size() is not the right size for ObjectArray.
You would have to do Array::InstanceSize(length) to get the
right size.

[srdjan, 2013-06-14 21:43:45]

PTAL

https://codereview.chromium.org/17104002/diff/3001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/17104002/diff/3001/runtime/vm/object.cc#newco...
runtime/vm/object.cc:9241: const intptr_t end_field_offset = cls.instance_size()
- kWordSize;
On 2013/06/14 21:04:03, siva wrote:
> cls.instance_size() is not the right size for ObjectArray.
> You would have to do Array::InstanceSize(length) to get the
> right size.

Done.

[siva, 2013-06-14 22:19:49]

lgtm

Wondering why we can not use VisitObjectPointers uniformly for all the cases. We
can discuss this on Monday.

https://codereview.chromium.org/17104002/diff/13001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/17104002/diff/13001/runtime/vm/object.cc#newc...
runtime/vm/object.cc:9272: Instance& result = Instance::Handle();
This can be moved below the call to CheckAndCanonicalize

https://codereview.chromium.org/17104002/diff/13001/runtime/vm/object.cc#newc...
runtime/vm/object.cc:9273: const Class& cls = Class::Handle(this->clazz());
This line is not needed anymore. Done inside CheckAndCanonicalizeFields

[srdjan, 2013-06-14 22:34:39]

https://codereview.chromium.org/17104002/diff/13001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/17104002/diff/13001/runtime/vm/object.cc#newc...
runtime/vm/object.cc:9272: Instance& result = Instance::Handle();
On 2013/06/14 22:19:49, siva wrote:
> This can be moved below the call to CheckAndCanonicalize

Done.

https://codereview.chromium.org/17104002/diff/13001/runtime/vm/object.cc#newc...
runtime/vm/object.cc:9273: const Class& cls = Class::Handle(this->clazz());
On 2013/06/14 22:19:49, siva wrote:
> This line is not needed anymore. Done inside CheckAndCanonicalizeFields

Done.

[srdjan, 2013-06-14 22:58:51]

Committed patchset #5 manually as r24059 (presubmit successful).