Issue 17103002: Remove support for + prefix in number literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17103002: Remove support for + prefix in number literals (Closed)

Created:
7 years, 6 months ago by hausner

Modified:
7 years, 6 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove support for + prefix in number literals Also fix some tests that expected + prefix in hex numbers to be illegal. According to our documentation, int.parse() accepts + for numbers in all formats/radixes. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=24051

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -104 lines)			Patch
M	runtime/vm/flow_graph_builder.h	View	1 chunk	+13 lines, -13 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View	5 chunks	+43 lines, -43 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	3 chunks	+2 lines, -12 lines	0 comments	Download
M	runtime/vm/scanner.cc	View	3 chunks	+4 lines, -11 lines	0 comments	Download
M	runtime/vm/scanner_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/token.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	tests/language/ternary_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/language/unary2_test.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/language/unary_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/math/math2_test.dart	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	tests/lib/math/math_test.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

7 years, 6 months ago (2013-06-14 21:16:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r24051 (presubmit successful).

Expand Messages | Collapse Messages